eranif wrote:Did you check the options under: Settings -> Global Editor Preferences -> Terminal?
Ok, this question I didn't expect, but...sure I did
.
eranif wrote:You can re-configure codelite to use another terminal.
Correct, but only to run the console program, which is in my opinion only a little part of an IDE. The configuration isn't considered, if you want to debug your own program (IMHO
the feature of an IDE) or try to open a shell in the "explorer"-window or from the tab-bar.
Where my changes really reviewed? Because they aren't only for the debugging-purpose. Was there ever a try to open a terminal different from "gnome-terminal", "konsole" and "xterm" out of the explorer or tab-bar?
Code: Select all
bool ProcUtils::Shell()
{
[...]
#else //non-windows
//try to locate the default terminal
wxString terminal;
wxString where;
if (Locate(wxT("gnome-terminal"), where)) {
terminal = where;
} else if (Locate(wxT("konsole"), where)) {
wxString path = wxGetCwd();
terminal << where << wxT(" --workdir \"") << path << wxT("\"");
} else if (Locate(wxT("xterm"), where)) {
terminal = where;
}
cmd = terminal;
#endif
return wxExecute(cmd, wxEXEC_ASYNC) != 0;
}
I expect "terminal" from XFCE wouldn't work. Am I right?
Code: Select all
void Manager::DbgStart ( long attachPid )
{
[...]
#if defined(__WXGTK__)
wxString where;
if ( !ExeLocator::Locate ( wxT ( "xterm" ), where ) ) { // COMMENT INSERTED FROM ME: Does a "which" on the provided string
wxMessageBox ( _( "Failed to locate 'xterm' application required by CodeLite, please install it and try again!" ), _("CodeLite" ), wxOK|wxCENTER|wxICON_WARNING, clMainFrame::Get() );
return;
}
#endif
[...]
}
It doesn't make really sense there to check if xterm is installed, when it's not used at all (haven't seen any call of it after that). Also xterm isn't listed as dependency (on the main page) for CodeLite either.
Why is the function...
Code: Select all
wxString ConsoleFinder::GetConsoleName()
{
[...]
}
...implemented but never used? We (the community) or you can put the complete complexity of linux-terminal-choose-freedom into that function and use it in any other function, where the usage could be useful. Right now there are many redundant parts of it, because *Locate is used that often in different modules.
eranif wrote:I chose xterm because it is the lowest common denominator for most Linux / FreeBSD distros
Eran
This could be true (at least I don't need it and haven't installed it) and I really don't want to discuss, which terminal emulator is the best, but this statement was a little bit confusing me in relation to your comment from
Sat Feb 06, 2010 1:59 am "Terminal setting not used for debugger?":
eranif wrote:Unfortunately yes -
I am not happy with it either 
You can submit a feature request for this.
Eran
So I was bypassing the feature request, did the change my self, post it in the main-forum and hope for a merge of it. Especially your comment was the reason, why I've done the change by my self. I want to change the situation, without to involve your time for it.
If it's not possible to merge it (why ever), then I want to stimulate a discussion about that current implementation and need of that dependency.
Now it's on you, if that change or maybe a little part of it, will be merged into trunk or at least discussed.
.