patchoffer for 4433 and 4375: autoinsert useroption

Discussion about CodeLite development process and patches
nemesis
CodeLite Enthusiast
Posts: 37
Joined: Fri Oct 01, 2010 8:32 pm
Genuine User: Yes
IDE Question: all
Contact:

patchoffer for 4433 and 4375: autoinsert useroption

Post by nemesis »

hi there!

searching for a useroption for the autoinsert for singlematches in the codecompletion i didn't find any. so here's a patchoffer for latest trunk (4428) and latest stable (4375 - which also includes the autocompletion patch from http://codelite.org/forum/viewtopic.php?f=13&t=1127).

the patch adds the useroption in the tagsmenu and modifies both ShowCompletionBox functions in cl_editor.cpp:2862 and 2908.
In

Code: Select all

void LEditor::ShowCompletionBox(const std::vector<TagEntryPtr>& tags, const wxString& word, wxEvtHandler* owner)
the autoinsert was hardset to false (used for abbreviations and clang-completion). i however found it confusing having an option for it and not affecting all cases, so i added it there, too.
In

Code: Select all

void LEditor::ShowCompletionBox(const std::vector<TagEntryPtr>& tags, const wxString& word, bool showFullDecl, bool autoHide, bool autoInsertSingleChoice)
the autoinsert was set by the variable autoInsertSingleChoice, which makes it obsolete now to set it in the code because it gets overridden by the usersetting.
defaultsetting is 'on', since this is, what the prototype gets initialized with in cl_editor.h:472.

greets,
nem

edit: rewrote the patch for revision 4433
You do not have the required permissions to view the files attached to this post.
Last edited by nemesis on Fri Oct 08, 2010 10:33 pm, edited 1 time in total.
User avatar
eranif
CodeLite Plugin
Posts: 6373
Joined: Wed Feb 06, 2008 9:29 pm
Genuine User: Yes
IDE Question: C++
Contact:

Re: patchoffer for 4428 and 4375: autoinsert useroption

Post by eranif »

the layout of the tags options dialog was modified completely, can u re-post the patch?

Eran
Make sure you have read the HOW TO POST thread
nemesis
CodeLite Enthusiast
Posts: 37
Joined: Fri Oct 01, 2010 8:32 pm
Genuine User: Yes
IDE Question: all
Contact:

Re: patchoffer for 4433 and 4375: autoinsert useroption

Post by nemesis »

done and replaced.

greets,
nem
foxmuldr
CodeLite Expert
Posts: 120
Joined: Sun May 10, 2009 6:56 am
Contact:

Re: patchoffer for 4433 and 4375: autoinsert useroption

Post by foxmuldr »

nemesis wrote:done and replaced.
Awesome work, nem. Thanks!

- Rick
Best regards,
Rick C. Hodgin
www.Visual-FreePro.org
www.LibSF.org
foxmuldr
CodeLite Expert
Posts: 120
Joined: Sun May 10, 2009 6:56 am
Contact:

Re: patchoffer for 4433 and 4375: autoinsert useroption

Post by foxmuldr »

Eran, thank you for implementing this patch. I know you said you don't use it, but many of us do. I also like the new layout with tick marks.

- Rick
Best regards,
Rick C. Hodgin
www.Visual-FreePro.org
www.LibSF.org
Post Reply