CL 3346 - Crash when opening build settings on MAC

[frank_frl]

Hi Eran,

CL 3346 crashes on MAC when I try to open the build settings.

Code: Select all

Process:         codelite [18489]
Path:            /Users/franklichtner/Dev/CodeLiteApp/CodeLite.app/Contents/MacOS/codelite
Identifier:      codelite
Version:         CodeLite version 1.0 (CodeLite version 1.0)
Code Type:       X86 (Native)
Parent Process:  launchd [80]

Interval Since Last Report:          47 sec
Crashes Since Last Report:           1
Per-App Interval Since Last Report:  0 sec
Per-App Crashes Since Last Report:   1

Date/Time:       2009-11-14 11:52:08.356 +0100
OS Version:      Mac OS X 10.5.8 (9L31a)
Report Version:  6
Anonymous UUID:  EE347130-9849-4ED8-B0C0-0084BE7FA0BE

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008
Crashed Thread:  0

Thread 0 Crashed:
0   libwx_macu-2.8.0.dylib        	0x009bd8d2 wxListCtrl::GetColumn(int, wxListItem&) const + 98
1   libwx_macu-2.8.0.dylib        	0x009c538f wxListCtrl::SetColumnWidth(int, int) + 239
2   codelite                      	0x00087047 CompilerPatternsPage::CompilerPatternsPage(wxWindow*, wxString const&) + 1591
3   codelite                      	0x000144bc AdvancedDlg::AddCompiler(SmartPtr<Compiler>, bool) + 156
4   codelite                      	0x0001512a AdvancedDlg::LoadCompilers() + 378
5   codelite                      	0x000161eb AdvancedDlg::AdvancedDlg(wxWindow*, unsigned long, int, wxString, wxPoint, wxSize, int) + 3723
6   codelite                      	0x00142a1e Frame::OnAdvanceSettings(wxCommandEvent&) + 190

No problem on PC with this revision.

Frank

[eranif]

This is wierd, since this code does do anything special.
Can you do update and re-build? I did a small change that might fix that

Eran

[frank_frl]

This is wierd, since this code does do anything special.
Can you do update and re-build? I did a small change that might fix that

Eran

Sorry Eran, same problem with V2.03353-RC1. This looks as if there is an invalid index given to wxListCtrl. I looked at your code in CompilerPatternsPage, but I couldn't find any call to wxListCtrl::GetColumn, where it's finally crashing.

Frank

[eranif]

I found in the code that column 2 was inserted before column 1, maybe this caused the crash.
I fixed this - can you try it again?

Eran

[frank_frl]

I found in the code that column 2 was inserted before column 1, maybe this caused the crash.
I fixed this - can you try it again?

Eran

Hi Eran works now with 3353.
I think you could make the first column somewhat wider then 200 pixels, specially on MAC where the system font is quit big.

BTW, I had a similar bug in my current project, where an invalid index didn't caused any bug on XP, but crashed immediately on Win2000 and on MAC. XP seems to be sometimes quiet gracious with such bugs.

Frank

[eranif]

Hi Eran works now with 3353.

Great news!
Thanks for checking this

Eran